Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add rename config property #51

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

TakaraShinya
Copy link

I added giving file name property.
Please merge my branch.

@canton7
Copy link
Owner

canton7 commented Apr 2, 2014

A couple of things:

  1. Why? What does this add? The point of the naming on cache files is that the name changes whenever a file is modified, so the webserver can apply very eager caching rules. I could maybe see the point of prepending the group name for debugging purposes, but then why not turn off minifing/combining altogether?
  2. Please update the README and default config file.
  3. This should probably also be added to the per-group options, and therefore also to the quickref

@TakaraShinya
Copy link
Author

  1. Beacause I didn't want to rename cache files. This cache files are make and renamed by webserver and cached on webserver. But my web application have many JS/CSS files are deployed to proxy server and get from proxy server by GET request. And then cached files on webserver not exist on proxy server.

2. OK. I'll do.

3. OK. I'll do.

@canton7
Copy link
Owner

canton7 commented Apr 4, 2014

Aha, so they're part of some sort of asset pipeline? That makes sense. Casset was never intended to be used in that way :)

Add an 'rename' property per-group. write this options explain.
@TakaraShinya
Copy link
Author

  1. I did. How is that?
  2. I don't know that I should write something to the quickref. Please teach me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants