Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Ignore the new grafana logql linter rules #503

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

DanielArndt
Copy link
Member

I wasn't able to figure out why these lint rules were failing. I tried a few different things but my grafana knowledge is limited.

For now, we ignore the rules to get the build running again.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that validate the behaviour of the software
  • I validated that new and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

I wasn't able to figure out why these lint rules were failing. I tried a
few different things but my grafana knowledge is limited.

For now, we ignore the rules to get the build running again.
@DanielArndt DanielArndt marked this pull request as ready for review September 27, 2024 19:19
@DanielArndt DanielArndt requested a review from a team as a code owner September 27, 2024 19:19
Copy link
Collaborator

@gruyaume gruyaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, the grafana lint project is not versioned and it recently got an update adding logql rule validation which broke this CI (and the Notary K8s one).

@DanielArndt DanielArndt merged commit 251ab6b into main Sep 27, 2024
12 checks passed
@DanielArndt DanielArndt deleted the ignore-grafana-logql-rules branch September 27, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants