integration: add background runner script #1594
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To eventually run these in parallel, we want to not have a single test instance hogging the console. Add a background-runner script which uses a detached screen session that also preserves the exit code of the program we're testing.
dbungert
force-pushed
the
pyintegration-step1
branch
from
82b59a9
to
170fba6
Compare
mwhudson
approved these changes
Mar 23, 2023
ogayot
reviewed
Mar 23, 2023
| @@ -0,0 +1,35 @@ | |||
| #!/usr/bin/python3 | |||
|
|
|||
| # Use screen to run a terminal program in the background until it exists. | |||
| #!/usr/bin/python3 | ||
|
|
||
| # Use screen to run a terminal program in the background until it exists. | ||
| # This process stays around in the forground. |
| '-D', '-m', # run detached from a terminal perspective, | ||
| # but the screen process doesn't background | ||
| ] | ||
| if args.logfile: |
| parser = argparse.ArgumentParser() | ||
| parser.add_argument('-l', '--logfile', default=None, | ||
| help='append output to logfile') | ||
| args, program = parser.parse_known_args() |
There was a problem hiding this comment.
sadly, there seems to be no way to tell argparse to parse options only at the beginning of the CLI. This means that doing:
scripts/background-runner ls -l /root
will interpret /root as the logfile for background-runner, and not an option of ls.
I suggest to disable prefix matching (i.e., setting allow_abbrev=False when instantiating ArgumentParser) to at least avoid stealing options that look like valid background-runner options.
Another alternative is to insert -- between the background-runner options and the rest of the CLI, e.g.:
scripts/background-runner -- ls -l
but with parse_known_args, argparse considers -- to be an extra argument, so it ends up first in program. We would need to remove it manually before calling subprocess.run:
parser.parse_known_args(["-l", "/tmp/log", "--", "ls", "/root"])
(Namespace(logfile='/tmp/log'), ['--', 'ls', '/root'])
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To eventually run these in parallel, we want to not have a single test instance hogging the console. Add a background-runner script which uses a detached screen session that also preserves the exit code of the program we're testing.