Use local project functional test template #263
Merged
+60
−50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosaboy
force-pushed
the
func-tests-voting-check-use-local-project-func-template
branch
from
87be919
to
a17da69
Compare
dosaboy
changed the title
dnegreira
previously approved these changes
Oct 3, 2024
Need to make sure we use the local functional test template when looking up voting info in zosci-config. Falls back to default charm-functional-jobs if no local one found.
dosaboy
force-pushed
the
func-tests-voting-check-use-local-project-func-template
branch
from
a17da69
to
72063d0
Compare
dnegreira
reviewed
Oct 3, 2024
| with open('osci.yaml', encoding='utf-8') as fd: | ||
| self._osci_config = yaml.safe_load(fd) | ||
| path = os.path.join(os.environ.get('CHARM_ROOT_PATH', ''), 'osci.yaml') | ||
| with open(path, encoding='utf-8') as fd: |
There was a problem hiding this comment.
When opening a file we should have in an exception catcher so that we can handle it properly
Something like:
try:
with open(path, encoding='utf-8') as fd:
self._osci_config = yaml.safe_load(fd)
except Exception as e:
print(f"Error opening {path}: {e}")
There was a problem hiding this comment.
no i actually want it to fail hard since if it cant find this information it cant do its job properly (which is what happened before)
dnegreira
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to make sure we use the local functional test template when looking up voting info in zosci-config. Falls back to default charm-functional-jobs if no local one found.