Cleanup old zaza models #258
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It can happen that when running the functests that the zaza model stays behind, either by cancelling the script or if the script has an error. This patch adds a cleanup check to verify if there are old zaza-* models before proceeding to run the functests. Signed-off-by: David Negreira <[email protected]>
dnegreira
force-pushed
the
functest-cleanup-zaza-models
branch
from
bf26b8d
to
5a686f5
Compare
dosaboy
reviewed
Oct 2, 2024
| @@ -110,6 +110,15 @@ done | |||
| # Install dependencies | |||
| which yq &>/dev/null || sudo snap install yq | |||
|
|
|||
| # Cleanup zaza-* models before proceeding | |||
| OLD_ZAZA_MODELS=$(juju list-models| grep -E "^zaza-\S+"|tr -d '*') | |||
| if [ -n "${OLD_ZAZA_MODELS}" ]; then | |||
There was a problem hiding this comment.
there is a helper function to do this now - https://github.com/canonical/stsstack-bundles/blob/main/openstack/tools/func_test_tools/common.sh#L1
it is already being run before and after a test run, do we really need to do it again here?
There was a problem hiding this comment.
well, this was not there when I wrote it yesterday, so I guess this PR can be dropped
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It can happen that when running the functests that the zaza model stays behind, either by cancelling the script or if the script has an error.
This patch adds a cleanup check to verify if there are old zaza-* models before proceeding to run the functests.