Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): bump requirements and build environment #4351

Merged
merged 3 commits into from
Sep 6, 2023
Merged

Conversation

mr-cal
Copy link
Collaborator

@mr-cal mr-cal commented Sep 6, 2023

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run make lint?
  • Have you successfully run pytest tests/unit?

  • update to ubuntu-22.04 and python 3.10
  • remove boilerplate comments
  • bump docs/requirements.txt

Signed-off-by: Callahan Kovacs <[email protected]>
@mr-cal mr-cal marked this pull request as draft September 6, 2023 17:08
Signed-off-by: Callahan Kovacs <[email protected]>
@mr-cal mr-cal marked this pull request as ready for review September 6, 2023 17:19
@mr-cal mr-cal changed the title [DRAFT] docs: update readthedocs build docs: update readthedocs build Sep 6, 2023
@mr-cal mr-cal closed this Sep 6, 2023
@mr-cal mr-cal reopened this Sep 6, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2023

Codecov Report

Merging #4351 (950c533) into main (dda7354) will not change coverage.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@           Coverage Diff           @@
##             main    #4351   +/-   ##
=======================================
  Coverage   89.19%   89.19%           
=======================================
  Files         300      300           
  Lines       20648    20648           
=======================================
  Hits        18418    18418           
  Misses       2230     2230           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mr-cal
Copy link
Collaborator Author

mr-cal commented Sep 6, 2023

The docs are building (logs and docs) but it is not adding a link in the PR.

This works in craft-providers, so I wonder if it is due to snapcore settings.

@mr-cal mr-cal changed the title docs: update readthedocs build chore: update readthedocs build Sep 6, 2023
@mr-cal mr-cal changed the title chore: update readthedocs build chore: fix readthedocs build Sep 6, 2023
@mr-cal mr-cal changed the title chore: fix readthedocs build chore(docs): bump requirements and build environment Sep 6, 2023
Copy link
Collaborator

@sergiusens sergiusens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lengau do we have renovate running here?

@lengau
Copy link
Contributor

lengau commented Sep 6, 2023

@sergiusens we don't, but since we've got most of the kinks out I've made a PR that gets the starbase config: #4352

@mr-cal mr-cal merged commit 9791156 into main Sep 6, 2023
11 checks passed
@mr-cal mr-cal deleted the docs-update branch September 6, 2023 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants