Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: sdcore_config interface tests #330

Closed
wants to merge 2 commits into from
Closed

fix: sdcore_config interface tests #330

wants to merge 2 commits into from

Conversation

patriciareinoso
Copy link
Contributor

Description

sdcore-config interface tests in https://github.com/canonical/charm-relation-interfaces are failing.
This PR adds a fixture of the NRF operator that will be used during sdcore-config provider tests

https://github.com/canonical/charm-relation-interfaces/actions/runs/10444868384/job/28919962915
https://juju.is/docs/sdk/write-interface-tests

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that validate the behaviour of the software
  • I validated that new and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have bumped the version of the library

@patriciareinoso patriciareinoso requested a review from a team as a code owner August 27, 2024 10:57
@patriciareinoso patriciareinoso force-pushed the fix-sdcore-config-interface-tests branch from 45cc693 to 1061a10 Compare August 27, 2024 10:58
@patriciareinoso patriciareinoso mentioned this pull request Aug 27, 2024
Closed
gruyaume
gruyaume requested changes Aug 27, 2024
View reviewed changes
Copy link
Collaborator

@gruyaume gruyaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make sure we address the following issues with interface tests prior:

  • The fixture should be different for different interface tests
  • The interface tests should not assess charm status

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gruyaume gruyaume gruyaume requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@patriciareinoso @gruyaume