Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: maven rockcraft plugin #728

Draft
wants to merge 30 commits into
base: main
Choose a base branch
from
Draft

feat: maven rockcraft plugin #728

wants to merge 30 commits into from
+183 −2

Commits on Oct 8, 2024

  1. feat: maven rockcraft plugin 

    Add overrides for craft-part maven plugin to allow
building Maven projects in rockcraft.

Namely:
 - Do not link /bin/java as it conflicts with the base-files_base slice
 - Restrict PATH to /usr/bin in order to avoid picking up unwanted JVM.
   Use can override PATH in the plugin environment settings if /usr/bin
   is not sufficient.
    @vpa1977
    vpa1977 committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    13f71d5 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2024

  1. test: only copy modules file

    @vpa1977
    vpa1977 committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    c76815f View commit details
    Browse the repository at this point in the history

  2. chore: fix comment in the test

    @vpa1977
    vpa1977 committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    810587a View commit details
    Browse the repository at this point in the history

  3. chore: fix copyright year for maven plugin

    @vpa1977
    vpa1977 committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    7e864d5 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into fix_maven

    @vpa1977
    vpa1977 authored Oct 9, 2024
    Configuration menu
    Copy the full SHA
    9a65ae9 View commit details
    Browse the repository at this point in the history

  5. test: remove maven download spam 

    - use -B to skip printing download logs
    @vpa1977
    vpa1977 committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    81b02fe View commit details
    Browse the repository at this point in the history

  6. test: log actual vs expected content 

    Log actual directory content and expected rock file name.
    @vpa1977
    vpa1977 committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    4aaa3e4 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'fix_maven' of github.com:vpa1977/rockcraft into fix_maven

    @vpa1977
    vpa1977 committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    19a5494 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2024

  1. test: use insecure-policy in copy args

    @vpa1977
    vpa1977 committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    30d1320 View commit details
    Browse the repository at this point in the history

  2. test: drop startup server from the test

    @vpa1977
    vpa1977 committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    a865428 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2024

  1. doc: add rockcraft-specific maven docs 

    Maven plugin is overriden in rockcraft.
Add rockcraft-specific instructions for the plugin.
    @vpa1977
    vpa1977 committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    26440ec View commit details
    Browse the repository at this point in the history

  2. lint(maven_plugin.rst): reformat file 

    - fix linter 'line too long' warnings
    @vpa1977
    vpa1977 committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    d47db08 View commit details
    Browse the repository at this point in the history

  3. test(plugin-maven): expand test comment

    @vpa1977
    vpa1977 committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    84de8ae View commit details
    Browse the repository at this point in the history

  4. doc(maven-plugin): update labels and links

    @vpa1977
    vpa1977 committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    a732138 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into fix_maven

    @vpa1977
    vpa1977 authored Oct 13, 2024
    Configuration menu
    Copy the full SHA
    4014687 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2024

  1. Merge branch 'main' into fix_maven

    @vpa1977
    vpa1977 authored Oct 15, 2024
    Configuration menu
    Copy the full SHA
    9c3985f View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2024

  1. Merge branch 'main' into fix_maven

    @vpa1977
    vpa1977 authored Oct 17, 2024
    Configuration menu
    Copy the full SHA
    5224edf View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2024

  1. fix: drop unused sitecustomize

    @vpa1977
    vpa1977 committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    bdaec03 View commit details
    Browse the repository at this point in the history

  2. Update tests/spread/rockcraft/plugin-maven/rockcraft.yaml 

    Co-authored-by: Tiago Nobrega <[email protected]>
    @vpa1977 @tigarmo
    vpa1977 and tigarmo authored Oct 21, 2024
    Configuration menu
    Copy the full SHA
    b68dce7 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2024

  1. fix: put /usr/bin in front 

    Do not touch path,  just put /usr/bin as a priority
    @vpa1977
    vpa1977 committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    5d745ea View commit details
    Browse the repository at this point in the history

  2. test: fix override stage-> build

    @vpa1977
    vpa1977 committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    940315a View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2024

  1. Update tests/spread/rockcraft/plugin-maven/task.yaml 

    Co-authored-by: Tiago Nobrega <[email protected]>
    @vpa1977 @tigarmo
    vpa1977 and tigarmo authored Oct 23, 2024
    Configuration menu
    Copy the full SHA
    53d2e6a View commit details
    Browse the repository at this point in the history

  2. Update tests/spread/rockcraft/plugin-maven/task.yaml 

    Co-authored-by: Tiago Nobrega <[email protected]>
    @vpa1977 @tigarmo
    vpa1977 and tigarmo authored Oct 23, 2024
    Configuration menu
    Copy the full SHA
    bb08f27 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into fix_maven

    @vpa1977
    vpa1977 authored Oct 23, 2024
    Configuration menu
    Copy the full SHA
    cff2516 View commit details
    Browse the repository at this point in the history

  4. Revert "Update tests/spread/rockcraft/plugin-maven/task.yaml" 

    This reverts commit bb08f27.

Chisel slices do not install /usr/bin symlink as it will cause
conflicts between different versions of jre slices.
    @vpa1977
    vpa1977 committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    d326747 View commit details
    Browse the repository at this point in the history

  5. lint: apply black

    @vpa1977
    vpa1977 committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    5bc22b6 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2024

  1. Merge branch 'main' into fix_maven

    @vpa1977
    vpa1977 authored Nov 6, 2024
    Configuration menu
    Copy the full SHA
    ea6196c View commit details
    Browse the repository at this point in the history

  2. fix: only drop /bin/java symlink 

    Maven plugin in rockcraft will work if we drop /bin/java symlink.
The JAVA_HOME variable will be set by java plugin
    @vpa1977
    vpa1977 committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    fae4383 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'fix_maven' of github.com:vpa1977/rockcraft into fix_maven

    @vpa1977
    vpa1977 committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    11550b9 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2024

  1. Merge branch 'main' into fix_maven

    @vpa1977
    vpa1977 authored Nov 7, 2024
    Configuration menu
    Copy the full SHA
    b0b319b View commit details
    Browse the repository at this point in the history