Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: reduce percy snapshot concurrency to resolve random test failures #1171

Closed
wants to merge 1 commit into from
Closed

fix: reduce percy snapshot concurrency to resolve random test failures #1171

wants to merge 1 commit into from

Conversation

mas-who
Copy link
Contributor

@mas-who mas-who commented Jan 17, 2025 •
edited
Loading

Done

  • reduced percy snapshot concurrency, this should fix random test failures in percy
  • based on discussion from this issue

QA

  • Ensure CI passes

Fixes

Fixes: #1170

@webteam-app
Copy link

Demo

Jenkins

demos.haus

@mas-who mas-who mentioned this pull request Jan 17, 2025
Merged
1 task
jmuzina
jmuzina reviewed Jan 17, 2025
View reviewed changes
Copy link
Member

@jmuzina jmuzina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! One small comment about documenting the fix.

.percy.yml Show resolved Hide resolved
@jmuzina
Copy link
Member

jmuzina commented Jan 17, 2025

Changes from this were rolled into #1159

@jmuzina jmuzina closed this Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmuzina jmuzina jmuzina approved these changes

Assignees
No one assigned
Labels
Review: Code +1 (with changes)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Percy chunk loading error
3 participants
@mas-who @webteam-app @jmuzina