Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: feat: Add row--4-cols-medium grid row #1146

Closed
wants to merge 1 commit into from

Conversation

jmuzina
Copy link
Member

@jmuzina jmuzina commented Oct 2, 2024

Done

  • Adds a new prop for the Row component, allowing the user to use the new grid row with 4 columns on medium. This will be the new default grid row starting in Vanilla v5. See Vanilla PR 5352 for more.
  • Note that this will not build until Vanilla 4.17.0 is released, as the feature is still in review on the Vanilla side.

QA

Storybook

To see rendered examples of all react-components, run:

yarn start

QA in your project

from react-components run:

yarn build
npm pack

Install the resulting tarball in your project with:

yarn add <path-to-tarball>

QA steps

  • Navigate to default grid row story.
  • See that it has the default "row" class and has 6 columns on the medium breakpoint.
  • Navigate to the 4 column medium grid row story.
  • See that it has the new "row--4-cols-medium" class and has 4 columns on the medium breakpoint.

Percy steps

  • Adds a new story: "Four column medium grid".
  • Updates the children of the existing default row story to show an example grid row, rather than just "children..."

@jmuzina jmuzina added Feature 🎁 New feature or request Review: Code needed Review: QA needed Don't merge Blocked ⛔ dependencies Pull requests that update a dependency file labels Oct 2, 2024
@webteam-app
Copy link

@jmuzina
Copy link
Member Author

jmuzina commented Oct 29, 2024

Closing to re-open a new PR that covers the new grid

@jmuzina jmuzina closed this Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants