Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CodeSnippet): Remove iframe from CodeSnippet example #1145

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Conversation

bartaz
Copy link
Member

@bartaz bartaz commented Oct 1, 2024

Removes iframe from CodeSnippet example to fix unstable Percy tests.

Drive-by: fix spacing in the JSX code elements example

Fixes #1144

QA

image

Drive-by: fix spacing in the JSX code elements example
@webteam-app
Copy link

@bartaz bartaz changed the title Remove iframe from CodeSnippet example fix(CodeSnippet): Remove iframe from CodeSnippet example Oct 1, 2024
Copy link
Contributor

@aaryanporwal aaryanporwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks for the fix!

@bartaz bartaz merged commit a021576 into main Oct 1, 2024
9 of 11 checks passed
@bartaz bartaz deleted the percy-iframe branch October 1, 2024 11:41
Copy link

github-actions bot commented Oct 1, 2024

🎉 This PR is included in version 1.3.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@bartaz bartaz mentioned this pull request Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky percy test: CodeSnippet's custom element iframe causing flaky percy test
3 participants