-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(skip-link): add SkipLink component [WD-15080] #1143
Conversation
cac479b
to
213084e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks mostly good! Just some small suggestions about the documentation and component interface :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you for the changes :)
🎉 This PR is included in version 1.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Done
SkipLink
component, based on Vanillap-skip--link
pattern. Added tests and Storybook for it.SkipLink
component inside theApplicationLayout
, so that it can be automatically obtained by React applications using theApplicationLayout
.a
element with thep-skip--link
class to your React application, and are also using theApplicationLayout
component, this can be a breaking change for you.Please make sure that you remove your manual addition of the skip link when upgrading react-components to the version that includes this change.
QA
Storybook
To see rendered examples of all react-components, run:
QA in your project
from
react-components
run:Install the resulting tarball in your project with:
QA steps
SkipLink
page of Storybook.Percy steps
SkipLink
component.Fixes
Fixes: WD-15080