Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add stepper and step components #1134

Merged
merged 1 commit into from
Oct 3, 2024
Merged

feat: add stepper and step components #1134

merged 1 commit into from
Oct 3, 2024

Conversation

anusha-c18
Copy link
Contributor

@anusha-c18 anusha-c18 commented Sep 18, 2024

Done

  • Added stepper wrapper component
  • Added step component with options to:
    • add a title for the step
    • enable/disable the step
    • select the step
    • display an optional label
    • display an optional link
    • display a progress line
    • display the index of the step
    • display an icon for the step
  • Added tests for the step component
  • Added tests for the stepper component

The current stepper component is of the standard size outlined in the spec. If required, the large size can be added at a later time.

QA

Storybook

To see rendered examples of all react-components, run:

yarn start

QA in your project

from react-components run:

yarn build
npm pack

Install the resulting tarball in your project with:

yarn add <path-to-tarball>

QA steps

  • Steps for QA.

Percy steps

  • List any expected visual change in Percy, or write something like "No visual changes expected" if none is expected.

Fixes

Fixes: # .

@webteam-app
Copy link

Copy link

This PR is being prevented from merging because it needs to be reviewed on Percy.

Go to Percy, find the build relevant to this PR and check if it looks as expected.

Once it's approved, add the label Review: Percy +1 to this PR.

1 similar comment
Copy link

This PR is being prevented from merging because it needs to be reviewed on Percy.

Go to Percy, find the build relevant to this PR and check if it looks as expected.

Once it's approved, add the label Review: Percy +1 to this PR.

@anusha-c18 anusha-c18 marked this pull request as ready for review September 18, 2024 13:28
@anusha-c18 anusha-c18 self-assigned this Sep 18, 2024
@pastelcyborg pastelcyborg self-requested a review September 19, 2024 22:00
Copy link
Contributor

@edlerd edlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA LGTM.
The linter has some errors, one idea for improvement and one concern regarding css namespacing.

src/components/Stepper/Step/Step.scss Outdated Show resolved Hide resolved
src/components/Stepper/Step/Step.tsx Show resolved Hide resolved
@anusha-c18 anusha-c18 force-pushed the stepper branch 2 times, most recently from 713d268 to ea71adb Compare September 30, 2024 23:05
@anusha-c18 anusha-c18 requested a review from edlerd September 30, 2024 23:09
src/components/Stepper/Step/Step.scss Outdated Show resolved Hide resolved
Copy link
Contributor

@edlerd edlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA and Code LGTM.

We need to have a look at percy and eventually approve the new screenshot introduced by this PR.

@anusha-c18 anusha-c18 merged commit 85c995d into main Oct 3, 2024
9 checks passed
@anusha-c18 anusha-c18 deleted the stepper branch October 3, 2024 08:41
Copy link

github-actions bot commented Oct 3, 2024

🎉 This PR is included in version 1.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants