Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update Col component size in Col.stories #1048

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

aaryanporwal
Copy link
Contributor

Done

  • Fixed a typo

QA

Storybook

To see rendered examples of all react-components, run:

yarn start

QA in your project

from react-components run:

yarn build
npm pack

Install the resulting tarball in your project with:

yarn add <path-to-tarball>

QA steps

  • Steps for QA.

Fixes

Fixes: # .

@webteam-app
Copy link

Demo starting at https://react-components-1048.demos.haus

@aaryanporwal aaryanporwal requested a review from edlerd February 28, 2024 08:54
Copy link
Contributor

@edlerd edlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please use docs: Update Col component size in Col.stories as commit message, otherwise this might trigger a build and release.

@aaryanporwal aaryanporwal changed the title fix(doc): Update Col component size in Col.stories.mdx docs: Update Col component size in Col.stories Feb 29, 2024
@aaryanporwal aaryanporwal requested a review from edlerd February 29, 2024 04:56
Copy link
Contributor

@edlerd edlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, perfect, thanks :)

@aaryanporwal aaryanporwal merged commit c3fb736 into canonical:main Mar 4, 2024
7 checks passed
@aaryanporwal aaryanporwal deleted the fix-col-doc branch March 4, 2024 08:09
Copy link

github-actions bot commented Mar 5, 2024

🎉 This PR is included in version 0.50.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants