fix: slider input field has wrong width #1041 #1042
Conversation
|
Demo starting at https://react-components-1042.demos.haus |
| &[disabled], | ||
| &[disabled="disabled"] { | ||
| @extend %vf-disabled-element; | ||
| } |
There was a problem hiding this comment.
Don't we need the same for the readonly attribute as well?
| &[disabled], | |
| &[disabled="disabled"] { | |
| @extend %vf-disabled-element; | |
| } | |
| &[readonly], | |
| &[readonly="readonly"] { | |
| @extend %vf-readonly-element; | |
| } | |
| &[disabled], | |
| &[disabled="disabled"] { | |
| @extend %vf-disabled-element; | |
| } |
| Workaround for: https: //github.com/canonical/react-components/issues/1041 | ||
| */ | ||
|
|
||
| %vf-readonly-element { |
There was a problem hiding this comment.
Why do we need to copy so much from Vanilla here?
This is extremely risky and fragile, as these internals of Vanilla are likely to be changed and this copy will not reflect that.
And I'm not sure if I understand how these styles are related to completely separate Slider component being broken?
There was a problem hiding this comment.
I'm fully aware it's very fragile, hence I clearly marked it as a workaround in the comment. This was meant to be a quick fix until we figure out a proper way of addressing this. I'll add more information to the linked issue.
Co-authored-by: Michele Lo Russo <[email protected]>
|
@bartaz Added a more detailed explanation in #1041 (comment) |
Done
QA
Storybook
To see rendered examples of all react-components, run:
QA in your project
from
react-componentsrun:Install the resulting tarball in your project with:
QA steps
Fixes
Fixes: # .