Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: table pagination description adjustments for all screen sizes #1038

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

mas-who
Copy link
Contributor

@mas-who mas-who commented Feb 7, 2024

Done

  • Fixed description text adjustment for small screen sizes. removed unnecessary useEffect dependencies that was previously causing weird render cycle issues.

QA

Storybook

To see rendered examples of all react-components, run:

yarn start

QA in your project

from react-components run:

yarn build
npm pack

Install the resulting tarball in your project with:

yarn add <path-to-tarball>

QA steps

  • On story book, try vary the screen size while looking at the TablePagination component. The pagination description (left of controls) should show X out of Y for small screen sizes consistently.
Screencast.from.07-02-2024.15.27.57.webm

@webteam-app
Copy link

Demo starting at https://react-components-1038.demos.haus

@mas-who mas-who force-pushed the fix-table-pagination-small-text branch 2 times, most recently from 5612abf to 04d83a1 Compare February 7, 2024 13:59
@mas-who mas-who force-pushed the fix-table-pagination-small-text branch from 04d83a1 to 0dfce4f Compare February 7, 2024 14:27
@lorumic
Copy link
Contributor

lorumic commented Feb 7, 2024

QA looks good in storybook - fingers crossed that this will solve the flickering issue in Anbox UI. :)

@lorumic lorumic merged commit f2f84f8 into canonical:main Feb 7, 2024
6 checks passed
Copy link

github-actions bot commented Feb 7, 2024

🎉 This PR is included in version 0.50.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants