Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: correctly import Button component on ContextualMenu story #1037

Conversation

rsmelo92
Copy link
Contributor

@rsmelo92 rsmelo92 commented Feb 2, 2024

Done

  • Adds correct import of default exported <Button /> component on <ContextualMenu />

Screenshots

Now

image

Before

image

QA

QA steps

  • Run the project
  • Open ContextualMenu stories
  • Check that Child element example is now fixed
  • Click on button of Child function
  • Check that it doesn't break anymore

Fixes

Fixes: #1033

@webteam-app
Copy link

rsmelo92 is not a collaborator of the repo

@petermakowski petermakowski merged commit e9c2743 into canonical:main Feb 5, 2024
6 checks passed
@petermakowski petermakowski changed the title fix: correctly import Button component on ContextualMenu story docs: correctly import Button component on ContextualMenu story Feb 5, 2024
@rsmelo92 rsmelo92 deleted the rsmelo92/fix-contextual-menu-issue-1033 branch February 5, 2024 14:30
Copy link

github-actions bot commented Feb 5, 2024

🎉 This PR is included in version 0.50.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues in ContextualMenu docs (Storybook)
3 participants