-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement externally controlled mode for TablePagination [WD-8505] #1034
Conversation
Demo starting at https://react-components-1034.demos.haus |
8b5575b
to
1c57c2b
Compare
1c57c2b
to
bbadd47
Compare
Decided to move the presentation part of the component to The cool thing is that the test I wrote previously for server-pagination didn't have to change at all, so it served as a bit of a setup for TDD 🙂 |
bbadd47
to
1dc2235
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for applying the new structure, I think this is way better than before!
Two tiny suggestions for further improvements below.
Signed-off-by: Mason Hu <[email protected]>
1dc2235
to
78f88d7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks for making this nice :)
Just one more idea to a bit more defensive implementation, feel free to address this or not.
🎉 This PR is included in version 0.50.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Done
TablePagination
componentTablePagination
component. You can refer to the test for example usage in externally controlled mode.QA
Storybook
To see rendered examples of all react-components, run:
QA in your project
from
react-components
run:Install the resulting tarball in your project with:
QA steps
TablePagination
if server pagination works.