Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): incremental update dependencies flagged by renovate [WD-8376] #1025

Merged
merged 1 commit into from
Jan 24, 2024
Merged

chore(deps): incremental update dependencies flagged by renovate [WD-8376] #1025

merged 1 commit into from
Jan 24, 2024

Conversation

mas-who
Copy link
Contributor

@mas-who mas-who commented Jan 23, 2024 •
edited
Loading

Done

  • Upgraded wait-on from 5.3.0 -> 7.2.0. Affects cypress testing.
  • Upgraded typescript from 4.9.5 -> 5.3.3. Affects build script.
  • Upgraded @typescript-eslint/eslint-plugin from 5.62.0 -> 6.19.1. Affects lint-js.
  • Upgraded @typescript-eslint/parser from 5.62.0 -> 6.19.1. Affects lint-js.
  • Upgraded ts-jest from 27.1.5 -> 29.1.2. Affects tests.
  • Upgraded stylelint from 15.11.0 -> 16.2.0. Affects lint-style.
  • Upgraded stylelint-config-recommended-scss from 5.0.2 -> 14.0.0. Affects lint-style.
  • Upgraded stylelint-order from 5.0.0 -> 6.0.4. Affects lint-style.
  • Upgraded stylelint from 2.0.0 -> 5.0.0. Affects lint-style.
  • Upgraded prettier from 2.8.8 -> 3.2.4. Affects lint-js.
  • Upgraded eslint-config-prettier from 8.10.0 -> 9.1.0. Affects lint-js.
  • Upgraded eslint-plugin-prettier from 4.2.1 -> 5.1.3. Affects lint-js.
  • Upgraded eslint-plugin-testing-library from 5.11.1 -> 6.2.0. Affects lint-js.
  • Upgraded @percy/storybook from 4.3.7 -> 5.0.1. Affects testing.
  • Upgraded @testing-library/cypress from 9.0.0 -> 10.0.1. Affects testing.
  • Upgraded @testing-library/jest-dom from 5.17.0 -> 6.2.1. Affects testing.
  • Upgraded babel-jest from 27.5.1 -> 29.7.0. Affects testing.
  • Upgraded cypress from 12.17.4 -> 13.6.3. Affects testing.
  • Upgraded jest from 27.5.1 -> 29.7.0. Affects testing.
  • Upgraded npm-package-json-lint from 5.4.2 -> 7.1.0. Affects lint.
  • Upgraded sass-loader from 10.5.1 -> 14.0.0. Affects build.
  • Upgraded @types/jest from 27.5.2 -> 29.5.11. Affects build.
  • Upgraded nanoid from 3.3.7 -> 5.0.4. Affects build.
  • Added jest-environment-jsdom, this is needed for jest upgrade (jest-environment-jsdom no longer ship with jest since v28)
  • use node lts in test github workflow
  • updated github action dependencies
  • updated Docerfile base node image version to 20
  • removed dependency resolution for string-width and strip-ansi and fixed resolution for jackspeak to 2.1.1.

QA

Storybook

To see rendered examples of all react-components, run:

yarn start

QA in your project

from react-components run:

yarn build
npm pack

Install the resulting tarball in your project with:

yarn add <path-to-tarball>

QA steps

  • Make sure ci completes fine and no tests fails
  • Spot checks on storybook demo server

@webteam-app
Copy link

Demo starting at https://react-components-1025.demos.haus

@mas-who mas-who force-pushed the update-dependencies branch 8 times, most recently from cb52325 to 9d4f4b3 Compare January 23, 2024 19:23
@mas-who
Copy link
Contributor Author

mas-who commented Jan 23, 2024

Not sure if the resolution dependencies strip-ansi and string-width can be upgraded since then are imported in the cliui module (some sub dependency of another package) with commonjs syntax (i.e. require) but latest versions of strip-ansi and string-width have es module syntax.

@mas-who mas-who changed the title chore(deps): incremental update dependencies flagged by renovate [WIP] chore(deps): incremental update dependencies flagged by renovate [WD-8376] Jan 23, 2024
@mas-who mas-who marked this pull request as ready for review January 23, 2024 19:32
edlerd
edlerd approved these changes Jan 24, 2024
View reviewed changes
Copy link
Contributor

@edlerd edlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bartaz
bartaz reviewed Jan 24, 2024
View reviewed changes
Dockerfile Outdated
@@ -2,7 +2,7 @@

# Build stage: Install yarn dependencies
# ===
FROM node:18 AS yarn-dependencies
FROM node:21 AS yarn-dependencies
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We used to only do LTS versions of node, which would be 20 in this case.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh okay sure, I just copied this update from the renovate PR. Will update this to 20

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no easy way to tell renovate to only do node LTS "equal" numbers. I think at some point we had it hardcoded in renovate config for couple versions forward, but seems it's gone from the shared config now.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still have it in Vanilla: https://github.com/canonical/vanilla-framework/blob/main/renovate.json#L17-L21

@mas-who mas-who force-pushed the update-dependencies branch 2 times, most recently from a04bb17 to 1c02a16 Compare January 24, 2024 08:15
@mas-who
Copy link
Contributor Author

mas-who commented Jan 24, 2024

Not sure if the resolution dependencies strip-ansi and string-width can be upgraded since then are imported in the cliui module (some sub dependency of another package) with commonjs syntax (i.e. require) but latest versions of strip-ansi and string-width have es module syntax.

The issue isn't with strip-ansi or string-width, according to this issue it's actually got to do with interaction between yarn's algorithm and jackspeak. The proposed solution is to fix jackspeak resolution to 2.1.1 or alternatively upgrade to yarn 3. I chose the first approach as upgrading to yarn 3 is a bit more involved and probably should be included in a separate PR.

@mas-who mas-who force-pushed the update-dependencies branch 2 times, most recently from b5e3e4b to 6319fae Compare January 24, 2024 11:01
@mas-who
chore(dep): incremental update dependencies flagged by renovate
ab4f2f9 
- Upgraded wait-on from 5.3.0 -> 7.2.0. Affects cypress testing.
- Upgraded typescript from 4.9.5 -> 5.3.3. Affects build script.
- Upgraded @typescript-eslint/eslint-plugin from 5.62.0 -> 6.19.1. Affects lint-js.
- Upgraded @typescript-eslint/parser from 5.62.0 -> 6.19.1. Affects lint-js.
- Upgraded ts-jest from 27.1.5 -> 29.1.2. Affects tests.
- Upgraded stylelint from 15.11.0 -> 16.2.0. Affects lint-style.
- Upgraded stylelint-config-recommended-scss from 5.0.2 -> 14.0.0. Affects lint-style.
- Upgraded stylelint-order from 5.0.0 -> 6.0.4. Affects lint-style.
- Upgraded stylelint from 2.0.0 -> 5.0.0. Affects lint-style.
- Upgraded prettier from 2.8.8 -> 3.2.4. Affects lint-js.
- Upgraded eslint-config-prettier from 8.10.0 -> 9.1.0. Affects lint-js.
- Upgraded eslint-plugin-prettier from 4.2.1 -> 5.1.3. Affects lint-js.
- Upgraded eslint-plugin-testing-library from 5.11.1 -> 6.2.0. Affects lint-js.
- Upgraded @percy/storybook from 4.3.7 -> 5.0.1. Affects testing.
- Upgraded @testing-library/cypress from 9.0.0 -> 10.0.1. Affects testing.
- Upgraded @testing-library/jest-dom from 5.17.0 -> 6.2.1. Affects testing.
- Upgraded babel-jest from 27.5.1 -> 29.7.0. Affects testing.
- Upgraded cypress from 12.17.4 -> 13.6.3. Affects testing.
- Upgraded jest from 27.5.1 -> 29.7.0. Affects testing.
- Upgraded npm-package-json-lint from 5.4.2 -> 7.1.0. Affects lint.
- Upgraded sass-loader from 10.5.1 -> 14.0.0. Affects build.
- Upgraded @types/jest from 27.5.2 -> 29.5.11. Affects build.
- Upgraded nanoid from 3.3.7 -> 5.0.4. Affects build.
- Added jest-environment-jsdom, this is needed for jest upgrade (jest-environment-jsdom no longer ship with jest since v28)
- use node lts in test github workflow
- updated github action dependencies
- updated Docerfile base node image version to 21
- removed dependency resolution for string-width and strip-ansi and fixed resolution for jackspeak to 2.1.1.

Signed-off-by: Mason Hu <[email protected]>
@mas-who mas-who force-pushed the update-dependencies branch from 6319fae to ab4f2f9 Compare January 24, 2024 11:10
bartaz
bartaz approved these changes Jan 24, 2024
View reviewed changes
Copy link
Member

@bartaz bartaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mas-who mas-who merged commit 1b8389f into canonical:main Jan 24, 2024
6 checks passed
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 0.48.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edlerd edlerd edlerd approved these changes

@bartaz bartaz bartaz approved these changes

Assignees
No one assigned
Labels
Maintenance 🔨 released Review: Code +1 Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mas-who @webteam-app @bartaz @edlerd