Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky percy test: CodeSnippet's custom element iframe causing flaky percy test #1144

Closed
aaryanporwal opened this issue Oct 1, 2024 · 1 comment · Fixed by #1145
Closed

Flaky percy test: CodeSnippet's custom element iframe causing flaky percy test #1144

aaryanporwal opened this issue Oct 1, 2024 · 1 comment · Fixed by #1145
Assignees
@bartaz
Labels
Bug 🐛 Something isn't working P3 Triaged Issue has been reviewed as part of legacy backlog grooming (project P3). released Triaged: v4 Triaged, to be implemented as part of Vanilla v4

Comments

@aaryanporwal
Copy link
Contributor

aaryanporwal commented Oct 1, 2024 •
edited
Loading

There's a recurring false positive test due to inconsistent rendering of iframe in CodeSnippet component's custom prop

Possible solution is to remove the iframe and replace it with some other custom element.

Example of the false positive:

image

https://percy.io/bb49709b/react-components/builds/36652560/changed/2002082707?browser=firefox&browser_ids=60&group_snapshots_by=similar_diff&other-browser=firefox&subcategories=approved&viewLayout=overlay&viewMode=new&width=1280&widths=1280
@aaryanporwal aaryanporwal added the Bug 🐛 Something isn't working label Oct 1, 2024
@bartaz bartaz self-assigned this Oct 1, 2024
@bartaz bartaz added P3 Triaged Issue has been reviewed as part of legacy backlog grooming (project P3). Triaged: v4 Triaged, to be implemented as part of Vanilla v4 labels Oct 1, 2024
@bartaz bartaz mentioned this issue Oct 1, 2024
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 1, 2024

🎉 This issue has been resolved in version 1.3.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bartaz bartaz

Labels
Bug 🐛 Something isn't working P3 Triaged Issue has been reviewed as part of legacy backlog grooming (project P3). released Triaged: v4 Triaged, to be implemented as part of Vanilla v4
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(CodeSnippet): Remove iframe from CodeSnippet example canonical/react-components
2 participants
@bartaz @aaryanporwal