Skip to content
This repository has been archived by the owner on Mar 4, 2024. It is now read-only.

Commit

Permalink
Merge pull request #296 from MathieuBordere/292/uv-1.44.2
Browse files Browse the repository at this point in the history
test_uv_tcp_connect: Disable test for certain uv versions
  • Loading branch information
stgraber authored Aug 9, 2022
2 parents 05a49e0 + 170a56c commit d2398c3
Showing 1 changed file with 12 additions and 0 deletions.
12 changes: 12 additions & 0 deletions test/integration/test_uv_tcp_connect.c
Original file line number Diff line number Diff line change
Expand Up @@ -217,6 +217,18 @@ TEST(tcp_connect, closeImmediately, setUp, tearDownDeps, 0, NULL)
TEST(tcp_connect, closeDuringHandshake, setUp, tearDownDeps, 0, NULL)
{
struct fixture *f = data;

/* This test fails for libuv version >= 1.44.2 due to changes in uv_run
* whereby queueing and processing the write_cb happen in the same loop
* iteration, not leaving us a chance to close without going through a lot
* of hoops.
* https://github.com/libuv/libuv/pull/3598 */
unsigned incompatible_uv = (1 << 16) | (44 << 8) | 2;
if (uv_version() >= incompatible_uv) {
CLOSE;
return MUNIT_SKIP;
}

CONNECT_CLOSE(2, TCP_SERVER_ADDRESS, 1);
return MUNIT_OK;
}
Expand Down

0 comments on commit d2398c3

Please sign in to comment.