feat: add new internal exponential "backoff" decorator util #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-dubs
force-pushed
the
add-custom-backoff
branch
4 times, most recently
from
45a759d
to
91a3a6d
Compare
a-dubs
force-pushed
the
add-custom-backoff
branch
from
91a3a6d
to
3f7e859
Compare
By implementing this as internal util, we avoid bringing in another dependency to add such simple functionality. Thorough unit tests were added to ensure this backoff decorator functions as desired.
This commit adds logic so that Quota related errors can be retried on VM creation. Adding this helps facilitate clearing of dangling resources on VM creation.
a-dubs
force-pushed
the
add-custom-backoff
branch
from
3dfbd1d
to
881f893
Compare
|
Thank you for the great work on this @a-dubs ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By implementing this as internal util, we avoid bringing in another dependency to add such simple functionality. Thorough unit tests were added to ensure this backoff decorator functions as desired.