feat(ec2): Allow using ec2 profile as creds #412
Conversation
TheRealFalcon
force-pushed
the
ec2-profiles
branch
from
aff6e50
to
4291d72
Compare
I think the idea behind SSO access is: SSO let you access your root AWS account. From the root account, one can create a non-root user. And those non-root user's credentials can be used as previously in pycloudlib. Does that work for you? |
Makes sense, but I was actually able to find the credentials. They're just listed on a different screen at login time rather than the original account page. I think this functionality is still useful though as it obviates the need to manage secret keys. |
There was a problem hiding this comment.
Changeset looks good to me, thanks.
I think we should extend https://github.com/canonical/pycloudlib/blob/main/docs/clouds/ec2.md to clarify on how to use the profile mode. WDYT?
| # If 'aws configure sso' has been run, 'profile' should be the only credentials needed | ||
| profile = "" # in ~/.aws/config | ||
|
|
||
| # With modern SSO, these should no longer be necessary. |
There was a problem hiding this comment.
Nit: With modern SSO sounds a bit pretentious and likely prone to age bad. Something like the following?
| # With modern SSO, these should no longer be necessary. | |
| # If profile is given, these are not necessary. |
I have a feeling I'm just missing something obvious, but with my SSO creds I can no longer get a secret key, but using a profile is an alternative that should work too.