nvme: run nvme connect-all --nbft before running the actual probes
#150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Marked as a draft because I haven't managed to get a NBFT available in the live installer environment ; using EDK II from timberland-sig. |
ogayot
force-pushed
the
nbft-connect-all
branch
from
e0d71c3
to
399c6a9
Compare
When running in an environment where a NBFT is available, we want probert to collect information about the remote NVMe drives too. This can be done by calling the `nvme connect-all --nbft` command. That said, running the command in the NVMe probe code itself will be too late for other probes (e.g., blockdev, filesystem, ...) to pick-up information about the remote NVMe drives. Instead, we run the command before dispatching the probes ; in a function called "activate_devices". In the long run, I would like to move some code that is currently in the probes (e.g., vgchange --activate=y) to the activate_devices function ; to avoid side effects in the probe code. Signed-off-by: Olivier Gayot <[email protected]>
ogayot
force-pushed
the
nbft-connect-all
branch
from
399c6a9
to
2f5c79f
Compare
|
I just tested this by dumping a NBFT and passing it back to qemu using However, it also looks like it is not necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running in an environment where a NBFT is available, we want probert to collect information about the remote NVMe drives too.
This can be done by calling the
nvme connect-all --nbftcommand. That said, running the command in the NVMe probe code itself will be too late for other probes (e.g., blockdev, filesystem, ...) to pick-up information about the remote NVMe drives.Instead, we run the command before dispatching the probes ; in a function called "activate_devices". In the long run, I would like to move some code that is currently in the probes (e.g.,
vgchange --activate=y) to the activate_devices function ; to avoid side effects in the probe code.