Add way to probe firmware information #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Olivier Gayot <[email protected]>
ogayot
force-pushed
the
probe-firmware
branch
3 times, most recently
from
0ac56da
to
d34f2e6
Compare
ogayot
force-pushed
the
probe-firmware
branch
2 times, most recently
from
267d68e
to
93e3fbb
Compare
For NVMe/TCP, we will want Subiquity to determine if booting with the boot FS on remote-storage is supported by the firmware. So far, it looks like we might need to identify if the firmware was built using the timberland-sig tree. We can rely on the "bios-vendor", "bios-release-date" and "bios-version" values so we now expose these pieces of information from probert. Since firmware related information should not change between two different probert invocations now make it part of a "firmware" prober, that Subiquity should realistically call only once. Signed-off-by: Olivier Gayot <[email protected]>
Signed-off-by: Olivier Gayot <[email protected]>
Signed-off-by: Olivier Gayot <[email protected]>
dbungert
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For NVMe/TCP, we will want Subiquity to determine if booting with the boot FS on remote-storage is supported by the firmware. So far, it looks like we might need to rely on the "bios-vendor" value so we now expose this information from probert.
Since firmware related information should not change between two different probert invocations now make it part of a "firmware" prober, that Subiquity should realistically call only once.