Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable cancel-in-progress for test.yaml #160

Merged
merged 4 commits into from
Jul 27, 2023

Conversation

yhaliaw
Copy link
Contributor

@yhaliaw yhaliaw commented Jul 6, 2023

After the cancellation issue is resolve the "cancel-in-progress" for test.yaml can be enabled.

@yhaliaw yhaliaw requested a review from a team as a code owner July 6, 2023 06:53
jdkandersson
jdkandersson previously approved these changes Jul 6, 2023
weiiwang01
weiiwang01 previously approved these changes Jul 6, 2023
@arturo-seijas
Copy link
Collaborator

What happened here with CI? Did the jobs get cancelled because of the change?

@yhaliaw yhaliaw closed this Jul 7, 2023
@yhaliaw yhaliaw reopened this Jul 7, 2023
yanksyoon
yanksyoon previously approved these changes Jul 7, 2023
Copy link
Contributor

@yanksyoon yanksyoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yhaliaw yhaliaw dismissed stale reviews from yanksyoon, weiiwang01, and jdkandersson via 6f18c7f July 7, 2023 06:32
Copy link
Contributor

@gregory-schiano gregory-schiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yhaliaw yhaliaw merged commit 33a71e5 into main Jul 27, 2023
53 checks passed
@yhaliaw yhaliaw deleted the re-enable-cancel-in-progress branch July 27, 2023 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants