Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CLI Client Handling Non-Interactive Terminal and Error Message for Non-Canonical Repo #247

Merged
merged 6 commits into from
Sep 24, 2024
Merged

Fix CLI Client Handling Non-Interactive Terminal and Error Message for Non-Canonical Repo #247

merged 6 commits into from
Sep 24, 2024

Conversation

zhijie-yang
Copy link
Contributor

Ping the @canonical/rocks team.

Description

This PR fixes the following issues:

  1. The CLI client is giving false positive results detecting non-interactive terminals.
  2. The CLI client dumps stack traceback when the regex fails to match a repo remote URL that does not belong to Canonical.

@zhijie-yang zhijie-yang requested a review from a team as a code owner September 20, 2024 10:23
@linostar linostar self-requested a review September 20, 2024 11:32
linostar
linostar approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@linostar linostar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zhijie-yang zhijie-yang marked this pull request as draft September 23, 2024 12:07
@zhijie-yang zhijie-yang marked this pull request as ready for review September 23, 2024 12:44
@zhijie-yang zhijie-yang merged commit 77149f1 into main Sep 24, 2024
6 checks passed
@zhijie-yang zhijie-yang deleted the ROCKS-1497/bugfix-cli-client branch September 24, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjdcordeiro cjdcordeiro cjdcordeiro approved these changes

@linostar linostar Awaiting requested review from linostar

@clay-lake clay-lake Awaiting requested review from clay-lake

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhijie-yang @linostar @cjdcordeiro