fix: checkout oci-factory repo before actor validation #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhijie-yang
force-pushed
the
HOTFIX-validate-actor-in-build-workflow
branch
from
2f534a6
to
edbe33c
Compare
zhijie-yang
force-pushed
the
HOTFIX-validate-actor-in-build-workflow
branch
from
edbe33c
to
f3a12dd
Compare
cjdcordeiro
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ping the @canonical/rocks team.
Description
This PR fixes the missing "checkout" in the Build Rock workflow, which causes the workflow to fail unexpectedly. This but is not captured by the testing workflow either, as the
mock-rocklives inside theoci-factoryrepo, which conceals this bug under the water.Related issues
https://github.com/canonical/oci-factory/actions/runs/10920792896/job/30311462832
Additional tests
https://github.com/canonical/oci-factory/actions/runs/10945495302/job/30389858407#step:3:1