Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[charm-dev] Install tox from pypi and other fixes #44

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

sed-i
Copy link
Collaborator

@sed-i sed-i commented Mar 20, 2024

In this PR:

@sed-i sed-i changed the title Install tox from pypi [charm-dev] Install tox from pypi and other fixes Mar 20, 2024
Copy link
Contributor

@townsend2010 townsend2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sed-i!

Thanks for the quick turnaround on this! I just have a question inline below. Otherwise, I assume you've tested this and works for the workflow you are trying to accomplish 🙂

v1/charm-dev.yaml Show resolved Hide resolved
@sed-i
Copy link
Collaborator Author

sed-i commented Mar 20, 2024

I assume you've tested this and works for the workflow you are trying to accomplish

Yep, cloud init completes successfully with a k8s and a lxd juju model bootstrapped and ready to use.

Copy link
Contributor

@townsend2010 townsend2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, LGTM! 👍

@townsend2010 townsend2010 merged commit 11a4bf9 into canonical:main Mar 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tox requires updating to version 3 in charm-dev image
2 participants