New attached windows need to be placed

[AlanGriffiths]

Alternative to #3675

[mattkae]

This does not fix the problem that I was having with cosmic-bg because LayerSurfaceV1::configure() happens before BasicWindowManager::place_new_surface(). The surface has not yet been placed when we send the configure event

[AlanGriffiths]

That sequence seems ... wrong. But I see it too:

[ 635173.015]  -> wl_compositor#6.create_surface(new id wl_surface#11)
[ 635173.030]  -> zwlr_layer_shell_v1#8.get_layer_surface(new id zwlr_layer_surface_v1#12, wl_surface#11, wl_output#3, 0, "wallpaper")
[ 635173.045]  -> zwlr_layer_surface_v1#12.set_anchor(15)
[ 635173.052]  -> zwlr_layer_surface_v1#12.set_exclusive_zone(-1)
[ 635173.058]  -> zwlr_layer_surface_v1#12.set_keyboard_interactivity(0)
[ 635173.066]  -> wl_surface#11.commit()
[ 635173.073]  -> wp_viewporter#9.get_viewport(new id wp_viewport#13, wl_surface#11)
[ 635173.102]  -> wp_fractional_scale_manager_v1#10.get_fractional_scale(new id wp_fractional_scale_v1#14, wl_surface#11)
[ 635173.788] zwlr_layer_surface_v1#12.configure(9, 0, 0)
[ 635173.807] zwlr_layer_surface_v1#12.configure(10, 1600, 900)

[AlanGriffiths]

The surface has not yet been placed when we send the configure event

Fixed now

[mattkae]

This makes it not crash 👍 But it doesn't make it work for cosmic-bg unlike my other PR. I'll investigate and let you know why. They appear the same on the surface

[mattkae]

I have fixed it with the latest commit @AlanGriffiths:

[Saviq]

32 - wlcs.Anchor/LayerSurfaceLayoutTest.* (Failed)

:)

[AlanGriffiths]

32 - wlcs.Anchor/LayerSurfaceLayoutTest.* (Failed)

:)

I understand why that broke, working on a fix

[AlanGriffiths]

Oops! Pulled the rug out of another corner

[AlanGriffiths]

@mattkae I'm not sure what the essential behaviour you want from 9247cc9 is. I've fixed the stuff it broke, but now not sure if the last two commits are even changing anything. (A shame you couldn't add a test)

Mattermost comment that "That [latest commit] did not break me"

[AlanGriffiths]

Not sure why (but I never tracked down the cause) this also seems to fix some intermittent yambar crashing

[mattkae]

Working well for me now 👍