-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin LXD dependency to stable-5.21
#277
Conversation
Signed-off-by: Julian Pelizäus <[email protected]> (cherry picked from commit d9bb070)
Signed-off-by: Julian Pelizäus <[email protected]>
Signed-off-by: Julian Pelizäus <[email protected]>
This reverts commit 36dc14a. Signed-off-by: Julian Pelizäus <[email protected]>
This reverts commit 8ba6b4f. Signed-off-by: Julian Pelizäus <[email protected]>
This reverts commit bda756d. Signed-off-by: Julian Pelizäus <[email protected]>
331dd58
to
3673c40
Compare
Mhhh looks we have to revert the changes to the But as it only affects the internal package it shouldn't be too much of an issue either. |
I can backport if needed, which commit do you need? |
If its only internal, feel free to revert for now, but be warned it will make it into stable-5.21 eventually. |
@tomponline I have quickly resolved the required chain of commits: The first produces a conflict because canonical/lxd@7798c53 potentially already got backported. |
This backports the necessary commits into `stable-5.21` that allow passing the request into the response `Render` func. See canonical/microcluster#277 (comment) for the origin of this request.
As part of #277 the changes to `Render` (originally introduced in #252) got reverted to allow tracking `[email protected]` which didn't contain the necessary changes to `Render`. After backporting the changes to LXD's `stable-5.21` with canonical/lxd#14409, we can restore the original changes using the latest version of LXD in `stable-5.21`.
No description provided.