internal/recover: Write the global DB patch on all members #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A fix for the same issue as in LXD: canonical/lxd#13754 (comment) Signed-off-by: Wesley Hershberger <[email protected]>
MggMuggins
changed the title
|
Looking at that query, I think we could pass the daemon name to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up on the test failures in #207. This is almost surely the same race condition I was seeing in LXD.
TL;DR we're selecting on the member's new address before
core_cluster_membershas been updated to include the new addresses. I haven't traced through this as finely as I did for LXD, but like over there, this is likely to be non-trivial/breaking to fix "correctly". Since the query is idempotent, creating the patch file on all nodes is the straightforward fix.