-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add github workflow for smoke-building on pushes and PRs #50
Conversation
I think this won't be of much use without large runners. |
1f81e77
to
cd66d8e
Compare
Bulk of the logic is in the common file. The aarch64 and x86_64 files include it while also setting MACHINE to a specific value. This way one can easily kas build something without having to know how to compose the files by hand. Signed-off-by: Zygmunt Krynicki <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Self-review
header: | ||
version: 8 | ||
includes: | ||
- kas-poky-snapd.common.yml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used this approach so that we can vary more than just the machine type. For instance I want to run CI for specific kernel versions as well as for machines, and this mode is just less convoluted.
.github/workflows/kas.yml
Outdated
- name: Run kas build | ||
# This hack makes DL_DIR and SSTATE_DIR overrides compatible with kas 2.6.3 in Ubuntu 22.04 | ||
run: | | ||
kas shell kas-poky-snapd.yml -c 'printf "DL_DIR = \"%s\"\n" "$DL_DIR" >>conf/local.conf && printf "SSTATE_DIR = \"%s\"\n" "$SSTATE_DIR" >>conf/local.conf && bitbake snapd-demo-image' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be re-written to use a script and be less quote-crazy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you should be able to simply place site.conf or auto.conf under build/conf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
879effa
to
8d6560b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
kas checkout ${{ matrix.kas }} | ||
- name: Run kas build | ||
run: | | ||
kas build kas-poky-snapd.yml --target snapd-demo-image |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we still have the demo image?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the push workflow stores that so I want to make sure it builds. We will test-boot it soon.
The workflow is a straightforward kas build with worker-local state used as download and sstate-cache directories. Signed-off-by: Zygmunt Krynicki <[email protected]>
No description provided.