Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add github workflow for smoke-building on pushes and PRs #50

Merged
merged 2 commits into from
Mar 7, 2024

Conversation

zyga
Copy link
Collaborator

@zyga zyga commented Mar 4, 2024

No description provided.

@zyga zyga requested a review from bboozzoo March 4, 2024 13:16
@zyga
Copy link
Collaborator Author

zyga commented Mar 4, 2024

I think this won't be of much use without large runners.

@zyga zyga force-pushed the workflow branch 10 times, most recently from 1f81e77 to cd66d8e Compare March 5, 2024 11:15
Bulk of the logic is in the common file. The aarch64 and x86_64 files include
it while also setting MACHINE to a specific value. This way one can easily
kas build something without having to know how to compose the files by hand.

Signed-off-by: Zygmunt Krynicki <[email protected]>
Copy link
Collaborator Author

@zyga zyga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self-review

header:
version: 8
includes:
- kas-poky-snapd.common.yml
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used this approach so that we can vary more than just the machine type. For instance I want to run CI for specific kernel versions as well as for machines, and this mode is just less convoluted.

- name: Run kas build
# This hack makes DL_DIR and SSTATE_DIR overrides compatible with kas 2.6.3 in Ubuntu 22.04
run: |
kas shell kas-poky-snapd.yml -c 'printf "DL_DIR = \"%s\"\n" "$DL_DIR" >>conf/local.conf && printf "SSTATE_DIR = \"%s\"\n" "$SSTATE_DIR" >>conf/local.conf && bitbake snapd-demo-image'
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be re-written to use a script and be less quote-crazy.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should be able to simply place site.conf or auto.conf under build/conf

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@zyga zyga force-pushed the workflow branch 8 times, most recently from 879effa to 8d6560b Compare March 7, 2024 13:08
Copy link
Collaborator

@bboozzoo bboozzoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kas checkout ${{ matrix.kas }}
- name: Run kas build
run: |
kas build kas-poky-snapd.yml --target snapd-demo-image
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we still have the demo image?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the push workflow stores that so I want to make sure it builds. We will test-boot it soon.

The workflow is a straightforward kas build with worker-local state used as
download and sstate-cache directories.

Signed-off-by: Zygmunt Krynicki <[email protected]>
@zyga zyga merged commit f3d6407 into master Mar 7, 2024
2 checks passed
@zyga zyga deleted the workflow branch March 7, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants