Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(machines): Add 'Register as DPU' to Add Machine form MAASENG-3948 #5567

Merged

Conversation

ndv99
Copy link
Contributor

@ndv99 ndv99 commented Dec 12, 2024

Blocked by #5566, which will need to be merged first.

Done

  • Added "Register as DPU" as an option to the "Add machine" form
  • (drive-by) Removed row/col elements on Add machine form, as they haven't been needed since we transitioned to using side panels.

QA steps

  • Add VITE_APP_DPU_PROVISIONING = true to your .env.local
  • Go to the machine list and click "Add machine"
  • Ensure a checkbox labelled "Register as DPU" is displayed at the bottom of the form.

Fixes

Resolves MAASENG-3948

Screenshots

image

Notes

Happy to change the position and text of the checkbox as needed.

@webteam-app
Copy link

@ndv99 ndv99 requested a review from tmerten December 12, 2024 11:19
Copy link
Collaborator

@tmerten tmerten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA: Works
Code: 👍

@ndv99 ndv99 marked this pull request as ready for review December 13, 2024 14:33
@ndv99 ndv99 merged commit ecb7b02 into canonical:main Dec 13, 2024
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants