Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: lxc image alias completions (from Incus) #14757

Merged
merged 2 commits into from
Jan 10, 2025

Conversation

kadinsayani
Copy link
Contributor

This PR adds completions for lxc image alias.

Summary of changes:

  • Adds a function cmpImageFingerprintsFromRemote which provides shell completion for image fingerprints.
  • Adds completions for lxc image alias create|list|delete|rename.

@kadinsayani kadinsayani force-pushed the image-alias-completions-incus branch 3 times, most recently from 9c1dede to 0be5b22 Compare January 9, 2025 14:14
@kadinsayani kadinsayani marked this pull request as ready for review January 9, 2025 14:14
Copy link
Member

@MusicDin MusicDin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🚀

@tomponline
Copy link
Member

@kadinsayani please can you rebase to get the doc fix

montag451 and others added 2 commits January 10, 2025 07:10
…for `image alias create`

Signed-off-by: montag451 <[email protected]>
(cherry picked from commit 41929ea4d6c78460cd1f555e8f0e814c79f32bf4)
Signed-off-by: Kadin Sayani <[email protected]>
License: Apache-2.0
@kadinsayani kadinsayani force-pushed the image-alias-completions-incus branch from 0be5b22 to 4a519f3 Compare January 10, 2025 14:10
@kadinsayani
Copy link
Contributor Author

@kadinsayani please can you rebase to get the doc fix

Rebased ✅

@tomponline tomponline merged commit f403cf3 into canonical:main Jan 10, 2025
28 checks passed
@kadinsayani kadinsayani deleted the image-alias-completions-incus branch January 10, 2025 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants