Add workflow to run e2e tests from lxd-ui

[edlerd]

Added a step to the GitHub test workflow, executing the e2e test suite from lxd-ui with a lxd backend built from the current branch from a PR or main branch.

We might extend this on the stable-5.21 and stable-5.0 branches, as we have dedicated test suites in lxd-ui for those. For older versions, we should continue skipping the e2e tests. I'd keep this as a second step in a followup PR.

This was successful on a fork, i.e. see this run.

[tomponline]

Hi @edlerd please can you work with @simondeziel to update this to use the pre-built LXD binaries we now have (that are compiled during the Code Tests phase) and to use the re-usable workflows for performance tuning and dependency installation.

Also i'd like to avoid building the docs twice, but they are built into the tarball i believe during the Code Tests phase so may be available already now.

[edlerd]

@simondeziel @tomponline Updated the workflow to consume the build artefacts from previous steps. Please give it another review.

[edlerd]

Also using the docs artefact by depending and downloading on that build step.

[edlerd]

I think all issues and concerns raised above have been addressed. Please give this another go @tomponline and @simondeziel

[edlerd]

This run on my fork was passing and producing coverage data for the LXD-UI tests.

[tomponline]

I think we're pretty close with this one now.

[tomponline]

@simondeziel happy with this one?

[tomponline]

out of interest how come this is needed?

[edlerd]

To be honest, this is pretty old code and I don't remember the exact details. I assume dotrun is creating files and folders under a different user, and we need to give it permission to do so.

[tomponline]

We might extend this on the stable-5.21 and stable-5.0 branches, as we have dedicated test suites in lxd-ui for those. For older versions, we should continue skipping the e2e tests. I'd keep this as a second step in a followup PR.

My understanding is that the LXD-UI from main should work on stable-5.21 and stable-5.0 branches, so can I just backport this test as part of our normal backport process?

[tomponline]

@edlerd looks like we missed blocking the edge builds on the ui tests passing

https://github.com/canonical/lxd/pull/14035/files#diff-1db27d93186e46d3b441ece35801b244db8ee144ff1405ca27a163bfe878957fL507

[edlerd]

We might extend this on the stable-5.21 and stable-5.0 branches, as we have dedicated test suites in lxd-ui for those. For older versions, we should continue skipping the e2e tests. I'd keep this as a second step in a followup PR.

My understanding is that the LXD-UI from main should work on stable-5.21 and stable-5.0 branches, so can I just backport this test as part of our normal backport process?

Basically yes.

The problem is the test suite needs to be adjusted for older versions. You can backport it, but need to adjust the command

npx playwright test --project chromium:lxd-latest-edge

to

npx playwright test --project chromium:lxd-5.21-edge

or

npx playwright test --project chromium:lxd-5.0-edge

to run the right tests for the version.

[tomponline]

The problem is the test suite needs to be adjusted for older versions. You can backport it, but need to adjust the command npx playwright test --project chromium:lxd-latest-edge to npx playwright test --project chromium:lxd-5.21-edge or npx playwright test --project chromium:lxd-5.0-edge to run the right tests for the version.

Please can you update so this is automatic using logic like this:

https://github.com/canonical/lxd/blob/main/.github/workflows/tests.yml#L683-L687

[edlerd]

Please can you update so this is automatic using logic like this:

https://github.com/canonical/lxd/blob/main/.github/workflows/tests.yml#L683-L687

Addressing this and other comments from above in the follow up PR #14553