Storage: Fix unnecessary dir project quota updates (from Incus) #14019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Documentation
hamistao
force-pushed
the
improve_quota_updates
branch
from
e5683e1 to
d8b90f9
Compare
github-actions
bot
removed
Documentation
hamistao
force-pushed
the
improve_quota_updates
branch
from
d8b90f9 to
735f9c1
Compare
…anges Signed-off-by: Stéphane Graber <[email protected]> Reported-by: Marius Klocke <[email protected]> (cherry picked from commit 4d4f97804721014a78fefb16d10126ae5556d436) Signed-off-by: hamistao <[email protected]> License: Apache-2.0
`DeleteProject` unsets the project for the path unnecessarily since the new project will be set afterwards. And that is an expensive operation since it implies another filepath walk. So this just unsets the quota on the project instead. Signed-off-by: hamistao <[email protected]>
hamistao
force-pushed
the
improve_quota_updates
branch
from
735f9c1 to
afa3cad
Compare
hamistao
changed the title
hamistao
changed the title
tomponline
changed the title
tomponline
previously approved these changes
Aug 30, 2024
|
@tomponline I am done with my tests and this should be safe to merge. Just pushed a small change to use an existing variable instead of getting the value again. |
Signed-off-by: hamistao <[email protected]>
tomponline
approved these changes
Aug 30, 2024
tomponline
changed the title
tomponline
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13115
This avoids setting project quotas when the project does not change (from Incus), and also avoids unnecessary project setting on
DeleteProject.Reported-by: Marius Klocke [email protected]
Closes #13813