Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lxc/publish: clarify that public means accessible to unauth'ed clients #14013

Merged
merged 2 commits into from
Sep 5, 2024

Conversation

simondeziel
Copy link
Member

No description provided.

@simondeziel simondeziel force-pushed the lxc-publish-short-help branch 2 times, most recently from f283ff5 to db44fa3 Compare August 29, 2024 17:28
@simondeziel simondeziel marked this pull request as ready for review August 29, 2024 18:01
@simondeziel simondeziel requested a review from tomponline August 29, 2024 18:01
@tomponline tomponline requested a review from markylaing August 30, 2024 10:26
@simondeziel simondeziel force-pushed the lxc-publish-short-help branch 2 times, most recently from f778202 to 7e338e0 Compare August 30, 2024 17:45
@tomponline
Copy link
Member

happy with this @markylaing ?

@simondeziel needs a rebase please

@simondeziel simondeziel force-pushed the lxc-publish-short-help branch from 7e338e0 to 6f48184 Compare September 3, 2024 15:59
@simondeziel
Copy link
Member Author

@tomponline this is the 2nd PR that fails due to what looks like a microceph regression on their edge channel (I've reported it internally).

@simondeziel simondeziel force-pushed the lxc-publish-short-help branch from 6f48184 to 9449066 Compare September 4, 2024 15:31
@simondeziel simondeziel force-pushed the lxc-publish-short-help branch from 9449066 to 90e365d Compare September 5, 2024 14:48
Copy link
Contributor

@markylaing markylaing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks :)

@tomponline tomponline merged commit 6970549 into canonical:main Sep 5, 2024
28 checks passed
@simondeziel simondeziel deleted the lxc-publish-short-help branch September 5, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants