Make lxd-agent install script compatible with SUSE #14003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was tested on Ubuntu 24.04, OpenSUSE 15.6 and Tumbleweed. Note that Tumbleweed has a compat symlink in place ( To test this, I used
I also tested this on a manually installed VM running SUSE 15 SP6 (ISO install). |
markylaing
reviewed
Aug 29, 2024
tomponline
added a commit
that referenced
this pull request
Aug 29, 2024
This assumed #14003 will be backported to `5.21/stable`.
simondeziel
force-pushed
the
lxd-agent-suse-guests
branch
2 times, most recently
from
8f623dd to
8a6e6d6
Compare
tomponline
reviewed
Sep 3, 2024
markylaing
reviewed
Sep 3, 2024
simondeziel
force-pushed
the
lxd-agent-suse-guests
branch
from
8a6e6d6 to
516c04d
Compare
https://www.freedesktop.org/software/systemd/man/latest/sd_booted.html: > Internally, this function checks whether the directory /run/systemd/system/ > exists. A simple check like this can also be implemented trivially in shell > or any other language. Signed-off-by: Simon Deziel <[email protected]>
Signed-off-by: Simon Deziel <[email protected]>
Signed-off-by: Simon Deziel <[email protected]>
Signed-off-by: Simon Deziel <[email protected]>
simondeziel
force-pushed
the
lxd-agent-suse-guests
branch
from
516c04d to
6d41293
Compare
|
@tomponline the CI fails for what seems to be a regression with microceph as it's consistently failing in this unrelated spot: https://github.com/canonical/lxd/actions/runs/10685425570/job/29621723179#step:12:50510 Update: this is not a regression in microceph but one in LXD introduced by #13995 |
tomponline
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13991