Project: Add lxd/project/limits and fix PowerFlex instance size limits
#13994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MggMuggins
changed the title
lxd/limits and fix instance size limits
MggMuggins
changed the title
lxd/limits and fix instance size limitslxd/limits and fix PowerFlex instance size limits
MggMuggins
force-pushed
the
limits-from-drivers
branch
from
a55def5 to
0b36059
Compare
tomponline
reviewed
Aug 28, 2024
I'll backport these changes as part of the normal process as they dont change the API or the DB. |
MggMuggins
force-pushed
the
limits-from-drivers
branch
from
02644b5 to
a0917f2
Compare
MggMuggins
force-pushed
the
limits-from-drivers
branch
5 times, most recently
from
4fae4c3 to
3a943fe
Compare
|
I've updated the PR description, made the requested change, and reworked how the default size was being passed around. |
roosterfish
requested changes
Aug 29, 2024
tomponline
changed the title
lxd/limits and fix PowerFlex instance size limitslxd/project/limits and fix PowerFlex instance size limits
MggMuggins
force-pushed
the
limits-from-drivers
branch
3 times, most recently
from
f5b84aa to
8bb252c
Compare
|
@roosterfish @tomponline This is ready to go again |
MggMuggins
force-pushed
the
limits-from-drivers
branch
from
8bb252c to
c137298
Compare
MggMuggins
force-pushed
the
limits-from-drivers
branch
from
c137298 to
194470b
Compare
tomponline
previously approved these changes
Sep 4, 2024
|
Thanks @MggMuggins please can you rebase to fix the conflict? |
Signed-off-by: Wesley Hershberger <[email protected]>
Signed-off-by: Wesley Hershberger <[email protected]>
Signed-off-by: Wesley Hershberger <[email protected]>
Signed-off-by: Wesley Hershberger <[email protected]>
…emSize Signed-off-by: Wesley Hershberger <[email protected]>
…size Signed-off-by: Wesley Hershberger <[email protected]>
These should be grabbed via the device driver Signed-off-by: Wesley Hershberger <[email protected]>
Since this function only return the distinct drivers, make way for GetStoragePoolDrivers to give a mapping of poolName:driverName. Signed-off-by: Wesley Hershberger <[email protected]>
Signed-off-by: Wesley Hershberger <[email protected]>
Signed-off-by: Wesley Hershberger <[email protected]>
Signed-off-by: Wesley Hershberger <[email protected]>
Signed-off-by: Wesley Hershberger <[email protected]>
We can't enforce that the defaultVMBlockFilesystemSize method doesn't use values in the driver before the driver is loaded. This will at least catch that usage in the test suite. Signed-off-by: Wesley Hershberger <[email protected]>
MggMuggins
dismissed stale reviews from tomponline and roosterfish
via
969efa3
MggMuggins
force-pushed
the
limits-from-drivers
branch
from
194470b to
969efa3
Compare
|
@tomponline Done |
tomponline
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12567
Moves some the contents of
lxd/projectinto a new modulelxd/project/limitsto remove an import cyclelxd/project -> lxd/storage/drivers -> lxd/project.lxd/projectsplit fairly cleanly in two; I tried to leave as much project-related API inlxd/projectas I could. Most of what is left there is the string processing code for prepending instance/volume names with the project name. This is used fairly heavily inlxd/storage/drivers.lxd/project/limitsnow contains just the code for enforcing project limits; the change in usage reads better IMO:This change allows us to import the storage drivers from
lxd/storage/driversinlxd/project/limitsto getDefaultVMBlockFilesystemSize.This introduces a new method to the internal driver interface (
defaultVMBlockFilesystemSize() string) and exposes a function fromlxd/storage/driversto convert a driver name to theDefaultVMBlockFilesystemSize.