-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overhaul network layout #1035
base: main
Are you sure you want to change the base?
Overhaul network layout #1035
Conversation
362dbb3
to
b5211f7
Compare
b5211f7
to
49c285d
Compare
5aba3f6
to
c5b65d6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love the network topology and how the existing form is reused. Still need to go through the css files though.
Please see some QA observations below:
|
d8201a1
to
de21bfe
Compare
Yes, good point, fixed the alignment.
I think we should hide the nav and search bar on small screens, which is done with recent changes.
I think the name is mandatory to switch to the yaml editor, and that should be fine in my opinion. The editor would only be used for some advanced configuration that is not supported in the ui.
I am now adding a line and three dots to downstream networks that have descendants. I discussed this with @piperdeck a while back, and I think we both agreed to only focus on direct neighbours in the topology and announcing further connections in this way. So we keep the focus on the current network and users can easily jump to the next network to explore further. |
3c3fe93
to
a9d2481
Compare
I've left some comments and feedback in a Figma page: https://www.figma.com/design/obSXJ4VkJUa2fHjt5lNf68/25.04-OVN-Networking?node-id=242-9623 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's working very nicely, just a few more observations.
Thanks for the comments and suggestions @piperdeck @mas-who and @lyubomir-popov |
LGTM from my end 👍 |
6d9aae7
to
df2f4ee
Compare
Signed-off-by: David Edler <[email protected]>
Signed-off-by: David Edler <[email protected]>
Signed-off-by: David Edler <[email protected]>
…work topology Signed-off-by: David Edler <[email protected]>
Signed-off-by: David Edler <[email protected]>
Signed-off-by: David Edler <[email protected]>
Signed-off-by: Nkeiruka <[email protected]> Signed-off-by: David Edler <[email protected]>
… design Signed-off-by: David Edler <[email protected]>
Signed-off-by: David Edler <[email protected]>
…nd message Signed-off-by: David Edler <[email protected]>
…sible Signed-off-by: David Edler <[email protected]>
- use new view for managed networks, remove old network overview - topology should be calculated for managed networks - search placeholder: "Search for key" - search over the description and field name - hide topology on yaml config - on creation: asterisk for name and uplink/parent - on creation: disable submit until a parent is selected - left align topology Signed-off-by: David Edler <[email protected]>
Signed-off-by: David Edler <[email protected]>
…ology descendents Signed-off-by: David Edler <[email protected]>
22bcff6
to
ee27b49
Compare
Signed-off-by: David Edler <[email protected]>
ee27b49
to
91752f7
Compare
…on network creation Signed-off-by: David Edler <[email protected]>
@piperdeck gave design +1 yesterday. @mas-who if you have some time on Monday, please give another review of the updates. |
Done
QA