Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lxd: Cherry picks (latest-candidate) #654

Merged
merged 1 commit into from
Dec 16, 2024
Merged

lxd: Cherry picks (latest-candidate) #654

merged 1 commit into from
Dec 16, 2024

Conversation

tomponline
Copy link
Member

Applies fix from canonical/lxd#14659

@tomponline
lxd: Cherry picks
139fe03 
Applies fix from canonical/lxd@8a40cd4

Signed-off-by: Thomas Parrott <[email protected]>
@tomponline tomponline changed the title lxd: Cherry picks lxd: Cherry picks (latest-candidate) Dec 16, 2024
@tomponline tomponline self-assigned this Dec 16, 2024
@tomponline tomponline marked this pull request as ready for review December 16, 2024 16:31
MusicDin
MusicDin approved these changes Dec 16, 2024
View reviewed changes
Copy link
Member

@MusicDin MusicDin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why branch name error is appearing, but commit seems fine.

Maybe if you changed target branch later, the check was not run, because it is comparing against latest-edge.

@tomponline tomponline merged commit 989f845 into canonical:latest-candidate Dec 16, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MusicDin MusicDin MusicDin approved these changes

@simondeziel simondeziel Awaiting requested review from simondeziel

Assignees

@tomponline tomponline

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomponline @MusicDin