snapcraft: Add nvidia-ctk as part of the binary tool for Container Device Interface spec generation
#470
Conversation
gabrielmougard
force-pushed
the
feat/nvidia-cdi-support
branch
from
82d1295 to
9926572
Compare
done :) |
snapcraft.yaml
Outdated
| - go | ||
| plugin: make | ||
| override-prime: |- | ||
| [ "$(uname -m)" != "x86_64" ] && [ "$(uname -m)" != "aarch64" ] && exit 0 |
There was a problem hiding this comment.
Does this only work on amd64 and arm64 then?
There was a problem hiding this comment.
Actually, it seems to also be supported for ppc64le
There was a problem hiding this comment.
... and s390x (it was not clearly stated in the repo but after a bit of digging I found this: https://rpmfind.net/linux/rpm2html/search.php?query=nvidia-container-toolkit)
There was a problem hiding this comment.
I'm fine with limiting it if you think there is a reason that this tool wouldn't be used on those architectures, even if it can be built. Can iGPUs be used on ppc64le and s390x?
There was a problem hiding this comment.
I asked @elezar
There was a problem hiding this comment.
It is my understanding that iGPUs are aarch64 only. For discrete GPUs our main platforms are x86_64 and aarch64. We do also build ppc64le packages, but it is my understanding that driver support for these architectures is being deprecated https://docs.nvidia.com/cuda/cuda-toolkit-release-notes/index.html#deprecated-or-dropped-architectures
Note that this does not mean that CDI should not be supported on ppc64le and s360x platforms, but just that the tooling to generate NVIDIA CDI specifications -- which relies on the driver -- may not work there if the driver is not available. One should still be able to build the go binary on these platforms though as device and library discovery using the driver is a runtime concern.
There was a problem hiding this comment.
Note that the linked c file should not be relevant on these platforms either since these are specific to discovering the location of driver libraries on WSL2-based systems. If the dxcore.so shared libraries are not present, these are never used.
There was a problem hiding this comment.
Thanks @elezar
@gabrielmougard are you able to address this please?
gabrielmougard
force-pushed
the
feat/nvidia-cdi-support
branch
from
9926572 to
64fdad6
Compare
…Device Interface spec generation Signed-off-by: Gabriel Mougard <[email protected]>
gabrielmougard
force-pushed
the
feat/nvidia-cdi-support
branch
from
64fdad6 to
2b7129f
Compare
| make binaries | ||
| mkdir -p "${CRAFT_PART_INSTALL}/bin/" | ||
| cp nvidia-ctk "${CRAFT_PART_INSTALL}/bin/" |
There was a problem hiding this comment.
Note: If you're only interested in the nvidia-ctk binary (or the nvidia-cdi-hook, I would assume), you should be able to run make cmd-nvidia-ctk or make cmd-nvidia-cdi-hook instead of make binaries to only build the single binary.
There was a problem hiding this comment.
@gabrielmougard what do you think?
thanks @elezar !
related to: canonical/lxd#13562