Remove doc build artifacts #308
Conversation
Signed-off-by: Simon Deziel <[email protected]>
Signed-off-by: Simon Deziel <[email protected]>
| # not needed once built | ||
| rm doc/html/.buildinfo | ||
| rm -rf doc/html/_sphinx_design_static/ | ||
| rm -rf doc/html/_sources/ |
There was a problem hiding this comment.
The sources are linked at the bottom of each page, so this will cause broken links in the footer.
There was a problem hiding this comment.
@simondeziel ah dam, please can you revert.
There was a problem hiding this comment.
Alternatively, we could probably find some way to use a different footer for snap builds. Not sure if the sources are needed for everyone (I would like to keep them for the online docs and normal local build though, since they are very useful when working with the docs).
There was a problem hiding this comment.
Can you link to the online ones always?
There was a problem hiding this comment.
This would be error-prone since the doc version shipped with the snap might differ from what is online - so the sources might not correspond to the documentation shipped with the snap.
There was a problem hiding this comment.
So you're thinking just removing the link for offline version?
There was a problem hiding this comment.
Yes - or more precisely, for the docs that are shipped with the snap. We can control this by setting some environment variable for the snap build.
The files/dirs being removed:
Without the above, the UI and the builtin doc still worked fine.