Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snapcraft: make bios-256k.bin optional at prime step #273

Merged

Conversation

mihalicyn
Copy link
Member

Unfortunately, we have to use this hack to make armhf/riscv builds to succeed, as on these two architectures we don't support QEMU at all. But prime step is still being executed which makes a whole snap build to fail [1], [2].

Also, let's always use bios-256k.bin SeaBIOS from the seabios package instead of from the QEMU tree.

[1] https://launchpadlibrarian.net/710544674/buildlog_snap_ubuntu_jammy_armhf_lxd-latest-edge_BUILDING.txt.gz
[2] https://launchpadlibrarian.net/710258725/buildlog_snap_ubuntu_jammy_riscv64_lxd-latest-edge_BUILDING.txt.gz

Unfortunately, we have to use this hack to make armhf/riscv
builds to succeed, as on these two architectures we don't support
QEMU at all. But prime step is still being executed which makes
a whole snap build to fail [1], [2].

Also, let's always use bios-256k.bin SeaBIOS from the seabios
package instead of from the QEMU tree.

[1] https://launchpadlibrarian.net/710544674/buildlog_snap_ubuntu_jammy_armhf_lxd-latest-edge_BUILDING.txt.gz
[2] https://launchpadlibrarian.net/710258725/buildlog_snap_ubuntu_jammy_riscv64_lxd-latest-edge_BUILDING.txt.gz

Signed-off-by: Alexander Mikhalitsyn <[email protected]>
@mihalicyn mihalicyn requested a review from tomponline as a code owner January 22, 2024 11:09
Copy link
Member

@tomponline tomponline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tomponline tomponline merged commit bed6baa into canonical:latest-edge Jan 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants