daemon.start: detect libfuse soname changes for fuse/fuse3 #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you add a comment to this code explaining what its doing and why its needed. Ta |
…se/fuse3 Also add comments explaining why this soname/base comparison is made. Signed-off-by: Simon Deziel <[email protected]>
simondeziel
force-pushed
the
libfuses
branch
from
7c093e5 to
ca6089c
Compare
|
@mihalicyn If you don't mind, please take a look at the newly added comments to be sure I understood the purpose of that detection. Thanks |
tomponline
approved these changes
Dec 10, 2023
mihalicyn
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #214 (comment)