Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop priming binaries that are already available in the base/core snap. See https://snapcraft.io/docs/build-and-staging-dependencies#heading--filtering for the explanation.
In the case of vim and for the
5.0/stable
channel, this would have saved us from using a known vulnerable vim version:In the above,
core20
ships... .15
while the5.0/stable
one has... .11
.The situation with differs for
latest/stable
as our snap's vim is ahead of whatcore22
provides:Even then, I think we should rely on what's provided by the base/core snap so that another team is responsible for that "shared infrastructure bit".