MicroOVN content interface support #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Max Asnaashari <[email protected]>
masnax
force-pushed
the
ovn-interface
branch
from
093528b to
14fd356
Compare
|
@masnax please can you link to the pending PR for microovn so we can monitor that before merging this? |
tomponline
approved these changes
Nov 30, 2023
|
@masnax is it possible to merge this without breaking microovn support before the content interface is added to microovn? |
Signed-off-by: Max Asnaashari <[email protected]>
Signed-off-by: Max Asnaashari <[email protected]>
masnax
force-pushed
the
ovn-interface
branch
from
14fd356 to
9f46799
Compare
|
@tomponline I dropped the commit that would break support until MicroOVN merges and backports the required changes. So now this can be merged. |
|
Here's the MicroOVN PR: canonical/microovn#107 |
tomponline
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pending the PR in MicroOVN, this adds support for the
ovn-confcontent interface in LXD.This will fix the issue of needing to restart LXD to pick up an OVN install, so LXD can detect as soon as MicroOVN is installed or removed, and update its symlinks appropriately.
The conditions and paths to the symlinks in
daemon.starthave also been updated to check for the existence of the created content interface directory, rather than theSNAP_COMMONdirectory of the respective snaps.