Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MicroCeph content interface #163

Merged
merged 3 commits into from
Sep 26, 2023

Conversation

masnax
Copy link
Contributor

@masnax masnax commented Sep 22, 2023

There's 2 changes here relative to the previous implementation:

  1. There are added entries in snapcraft.yaml for the hooks connect-plug-ceph-conf and disconnect-plug-ceph-conf which add the lxd-support and system-observe plugs, allowing super-privileged access to call aa-exec -p unconfined.

  2. MicroCeph handling is removed from daemon.start since we have confirmed that autoconnection to the microceph snap does indeed work.

On point 1, I think there was a bit of user-error in my final attempt last night. I've been installing the snaps in a VM with

snap remove lxd --purge ; snap install lxd ; snap install --dangerous /root/lxd.broken.snap

but I may have used the wrong snap last night, because rebuilding and trying again today, I can actually see the error:

error: cannot perform the following tasks:
- Run hook connect-plug-ceph-conf of snap "lxd" (run hook "connect-plug-ceph-conf":
-----
cat: /proc/self/attr/current: Permission denied
/snap/lxd/x1/snap/hooks/connect-plug-ceph-conf: 6: exec: aa-exec: Permission denied
-----)

Which means this one isn't actually hidden behind publishing like I thought. Can't say the same for the other errors, so I've still left out the common file handling until we can test that locally.

I've also confirmed that with the additional lines for lxd-support and system-observe, I don't get that error when the hooks fire.

@masnax masnax requested a review from tomponline September 22, 2023 15:55
@masnax
Copy link
Contributor Author

masnax commented Sep 22, 2023

Adding you as a reviewer so it's on your radar, but no rush to push this till next week :)

@tomponline tomponline merged commit f25cea7 into canonical:latest-edge Sep 26, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants