Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's 2 changes here relative to the previous implementation:
There are added entries in
snapcraft.yaml
for the hooksconnect-plug-ceph-conf
anddisconnect-plug-ceph-conf
which add thelxd-support
andsystem-observe
plugs, allowing super-privileged access to callaa-exec -p unconfined
.MicroCeph handling is removed from
daemon.start
since we have confirmed that autoconnection to the microceph snap does indeed work.On point 1, I think there was a bit of user-error in my final attempt last night. I've been installing the snaps in a VM with
but I may have used the wrong snap last night, because rebuilding and trying again today, I can actually see the error:
Which means this one isn't actually hidden behind publishing like I thought. Can't say the same for the other errors, so I've still left out the
common
file handling until we can test that locally.I've also confirmed that with the additional lines for
lxd-support
andsystem-observe
, I don't get that error when the hooks fire.