Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "tests/network-ovn: ignore empty ACL logs if not using deb" #380

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

simondeziel
Copy link
Member

This should work in latest/edge now that canonical/lxd#14327 was merged.

Copy link
Member

@tomponline tomponline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@simondeziel
Copy link
Member Author

@gabrielmougard looks like it didn't work in CI with:

+ snap list lxd
Name  Version      Rev    Tracking     Publisher    Notes
lxd   git-62be87a  31908  latest/edge  canonical**  in-cohort

@gabrielmougard
Copy link
Contributor

Taking a look

@gabrielmougard
Copy link
Contributor

gabrielmougard commented Jan 8, 2025

@simondeziel I tried locally with LXD_SIDELOAD_PATH=/root/lxd ./bin/local-run tests/network-ovn latest/edge (inside a VM with the lxd-ci profile as per the README instruction) with

root@v1:~# snap list
Name      Version                 Rev    Tracking       Publisher   Notes
core24    20240920                609    latest/stable  canonical✓  base
lxd       git-72baca0             31917  latest/edge    canonical✓  in-cohort
microovn  24.03.2+snap83bae7d11f  694    latest/edge    canonical✓  in-cohort
snapd     2.66.1                  23258  latest/stable  canonical✓  snapd

And I made it work. I guess the lxd version used here do not contain the commit with the ACL log fix.

Copy link
Member

@tomponline tomponline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and passing on latest/edge now.

@tomponline tomponline marked this pull request as ready for review January 8, 2025 11:40
@tomponline tomponline merged commit 19fab31 into canonical:main Jan 8, 2025
175 of 179 checks passed
@simondeziel simondeziel deleted the microovn-acl-logs branch January 8, 2025 13:44
@simondeziel
Copy link
Member Author

And I made it work. I guess the lxd version used here do not contain the commit with the ACL log fix.

Thanks. I need to revisit my expectation of snap publication speed it seems. Sorry for making you check this needlessly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants